Add gauges for allocated memory for queued UDP and TCP packages#1501
Closed
peterbueschel wants to merge 1 commit intoprometheus:masterfrom
Closed
Add gauges for allocated memory for queued UDP and TCP packages#1501peterbueschel wants to merge 1 commit intoprometheus:masterfrom
peterbueschel wants to merge 1 commit intoprometheus:masterfrom
Conversation
peterbueschel
force-pushed
the
peterbueschel/add-rx-tx-queue-lengths
branch
2 times, most recently
from
50e290e to
dbdd429
Compare
SuperQ
reviewed
Sep 30, 2019
collector/infiniband_linux.go
Outdated
…d_bytes and tx_queued_bytes. For UDP datagrams an additional collector 'udp_queues' can be used to expose the total lengths of the tx_queue and rx_queue. @SuperQ and @discordianfish this changes gives us the option to check for overloaded UDP + TCP processing. The names of the new TCP states and the UDP metric can be discussed. The current reasons are just: I don't want to add another collector for the same exposed file, so I just added the new states to the tcpstat collector. I chose the name 'udp_queue' instead of 'udpstat' as UDP has no state. Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
peterbueschel
force-pushed
the
peterbueschel/add-rx-tx-queue-lengths
branch
from
dbdd429 to
99d5944
Compare
Contributor
Author
|
Create another PR #1502 without file mentioned files |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@SuperQ and @discordianfish this changes gives us the option to check for overloaded UDP + TCP processing.
The names of the new TCP states and the UDP metric can be discussed.
The current reasons are just:
Signed-off-by: Peter Bueschel peter.bueschel@logmein.com