Skip to content

Comments

Add gauges for allocated memory for queued UDP and TCP packages#1502

Closed
peterbueschel wants to merge 2 commits intoprometheus:masterfrom
goto-opensource:peterbueschel/add-udp-rx-tx-queues
Closed

Add gauges for allocated memory for queued UDP and TCP packages#1502
peterbueschel wants to merge 2 commits intoprometheus:masterfrom
goto-opensource:peterbueschel/add-udp-rx-tx-queues

Conversation

@peterbueschel
Copy link
Contributor

  • Two new states will be added to the tcpstat collector called rx_queued_bytes and tx_queued_bytes.
  • For UDP datagrams an additional collector 'udp_queues' can be used to expose the total lengths of the tx_queue and rx_queue.

@SuperQ and @discordianfish this changes gives us the option to check for overloaded UDP + TCP processing.
The names of the new TCP states and the UDP metric can be discussed.
The current reasons are just:

  • I don't want to add another collector for the same exposed file, so I just added the new states to the tcpstat collector.
  • I chose the name 'udp_queue' instead of 'udpstat' as UDP has no state.

Signed-off-by: Peter Bueschel peter.bueschel@logmein.com

…d_bytes and tx_queued_bytes.

For UDP datagrams an additional collector 'udp_queues' can be used to expose the total lengths of the tx_queue and rx_queue.
@SuperQ and @discordianfish this changes gives us the option to check for overloaded UDP + TCP processing.
The names of the new TCP states and the UDP metric can be discussed.
The current reasons are just:

I don't want to add another collector for the same exposed file, so I just added the new states to the tcpstat collector.
I chose the name 'udp_queue' instead of 'udpstat' as UDP has no state.
Signed-off-by: Peter Bueschel <peter.bueschel@logmein.com>
@peterbueschel
Copy link
Contributor Author

Sorry again, fight with the DCO and spell checker. New one in #1503

@peterbueschel peterbueschel deleted the peterbueschel/add-udp-rx-tx-queues branch September 30, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant