Fix build tags for collectors#1745
Merged
Conversation
Signed-off-by: Jeffrey Stoke <me@arhat.dev>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing build tags for collectors seems out of sync, and when I try to build for
freebsdwith build tagnoboottime noexec nomeminfo nonetdev nozfs nofilesystemjust fails with:which is not the expected behavior I suppose, because zfs was included even with
nozfstag.This PR is an attempt to fix collectors' build tags, and once merged, users should be able to build with/without specific collectors with correct build tags.
/cc @SuperQ @discordianfish