Conversation
Member
SuperQ
commented
Jun 15, 2020
SuperQ
commented
- [BUGFIX] filesystem_freebsd: Fix label values filesystem_freebsd: Fix label values #1728
- [BUGFIX] Update prometheus/procfs to fix log noise Update prometheus/procfs #1735
- [BUGFIX] Fix build tags for collectors Fix build tags for collectors #1745
- [BUGFIX] Handle no data from powersupplyclass Handle no data from powersupplyclass #1747, Fix up powersupplyclass error #1749
We must know the length of the various filesystem C strings before turning them from a byte array into a Go string, otherwise our Go strings could contain null bytes, corrupting the label values. Signed-off-by: David O'Rourke <david.orourke@gmail.com>
Signed-off-by: David O'Rourke <david.orourke@gmail.com>
Signed-off-by: David O'Rourke <david.orourke@gmail.com>
Signed-off-by: David O'Rourke <david.orourke@gmail.com>
Signed-off-by: Jeffrey Stoke <me@arhat.dev>
Handle the case when /sys/class/power_supply doesn't exist. Fixes logging error spam. Requires prometheus/procfs#308 Signed-off-by: Ben Kochie <superq@gmail.com>
Fixes: #1721 Signed-off-by: Ben Kochie <superq@gmail.com>
Switch to go `%w` error verb and errors.Is(). Signed-off-by: Ben Kochie <superq@gmail.com>
Update changelog and version for 1.0.1 release. Signed-off-by: Ben Kochie <superq@gmail.com>
roidelapluie
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.