Merged
Conversation
Member
Author
|
This isn't it either. The problem is, this function returns the error from This appears to be a raw syscall error, and not something defined as a Go error. |
SuperQ
force-pushed
the
bjk/powersupplyclass_invalid
branch
from
c639cc8 to
5e29cea
Compare
Member
|
It is a PathError then |
Member
|
It is a path error with a Unwrap error so that error.is could work |
Member
|
Please remove wrapping at L190 and use os.IsNotExist |
SuperQ
force-pushed
the
bjk/powersupplyclass_invalid
branch
from
5e29cea to
aa0cc29
Compare
Switch to go `%w` error verb and errors.Is(). Signed-off-by: Ben Kochie <superq@gmail.com>
SuperQ
force-pushed
the
bjk/powersupplyclass_invalid
branch
from
aa0cc29 to
39c6174
Compare
roidelapluie
approved these changes
Jun 15, 2020
discordianfish
approved these changes
Jun 15, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Kochie superq@gmail.com