add node_network_address collector by binjip978 · Pull Request #2105 · prometheus/node_exporter

binjip978 · 2021-07-30T04:52:58Z

emit (interface, addr, netmask, scope) labels for every network
interface

Signed-off-by: binjip978 binjip978@gmail.com

emit (interface, addr, netmask, scope) labels for every network interface Signed-off-by: binjip978 <binjip978@gmail.com>

collector/network_address.go

Signed-off-by: binjip978 <binjip978@gmail.com>

nathansgreen · 2021-09-02T20:04:08Z

This is just to repeat what I said on 1845. I noticed that the IP address is labeled as addr, but it seems to me that address (unabbreviated) works better. It's the same label that is used by MAC addresses in network_info, and seems more consistent with the naming style for other labels.

Signed-off-by: binjip978 <binjip978@gmail.com>

binjip978 · 2021-09-03T05:26:11Z

updated to more consistent naming

# HELP node_network_address_entries node network address by device
# TYPE node_network_address_entries gauge
node_network_address_entries{address="100.112.225.48",device="tailscale0",netmask="32",scope="global"} 1
node_network_address_entries{address="127.0.0.1",device="lo",netmask="8",scope="link-local"} 1
node_network_address_entries{address="172.17.0.1",device="docker0",netmask="16",scope="global"} 1
node_network_address_entries{address="192.168.100.5",device="wlp61s0",netmask="24",scope="global"} 1
node_network_address_entries{address="192.168.122.1",device="virbr0",netmask="24",scope="global"} 1
node_network_address_entries{address="192.168.39.1",device="virbr1",netmask="24",scope="global"} 1
node_network_address_entries{address="::1",device="lo",netmask="128",scope="link-local"} 1
node_network_address_entries{address="fd7a:115c:a1e0:ab12:4843:cd96:6270:e130",device="tailscale0",netmask="128",scope="global"} 1

discordianfish · 2021-09-03T08:46:51Z

Great! Looks good to me in general, but not completely sure about the metric name.
What about node_network_addresses (to keep it simple, everything here are 'entries') or node_network_address_info to be more in line with other info metrics like node_network_info. Leaning towards the later. @SuperQ wdyt?
@nathansgreen You seem to have good opinions about naming stuff, what do you think about the metric name?

SuperQ · 2021-09-03T09:32:17Z

node_network_address_info is what I would prefer, as these will always have a 1 value.

Signed-off-by: binjip978 <binjip978@gmail.com>

collector/netdev_common.go

discordianfish

Beside the q around that new build flag, LGTM!

SuperQ

LGTM

* [CHANGE] Add path label to rapl collector #2146 * [FEATURE] Add os release collector #2094 * [FEATURE] Add node_network_address collector #2105 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Add collector.ethtool.metrics-include #2117 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

* [CHANGE] Add path label to rapl collector #2146 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Add collector.ethtool.metrics-include #2117 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector #2146 * [FEATURE] Add support for monitoring GPUs on Linux #1998 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] Support glob textfile collector directories #1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering #2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector #2146 * [FEATURE] Add support for monitoring GPUs on Linux #1998 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] Support glob textfile collector directories #1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering #2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [ENHANCEMENT] Add threads metrics to processes collector #2164 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector #2146 * [CHANGE] Exclude filesystems under /run/credentials #2157 * [FEATURE] Add support for monitoring GPUs on Linux #1998 * [FEATURE] Add Darwin thermal collector #2032 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] Support glob textfile collector directories #1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering #2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [ENHANCEMENT] Add DMI collector #2131 * [ENHANCEMENT] Add threads metrics to processes collector #2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector #2169 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector #2146 * [CHANGE] Exclude filesystems under /run/credentials #2157 * [FEATURE] Add darwin powersupply collector #1777 * [FEATURE] Add support for monitoring GPUs on Linux #1998 * [FEATURE] Add Darwin thermal collector #2032 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] Support glob textfile collector directories #1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering #2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [ENHANCEMENT] Add DMI collector #2131 * [ENHANCEMENT] Add threads metrics to processes collector #2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector #2169 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector #2146 * [CHANGE] Exclude filesystems under /run/credentials #2157 * [FEATURE] Add lnstat collector for metrics from /proc/net/stat/ #1771 * [FEATURE] Add darwin powersupply collector #1777 * [FEATURE] Add support for monitoring GPUs on Linux #1998 * [FEATURE] Add Darwin thermal collector #2032 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] Support glob textfile collector directories #1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering #2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [ENHANCEMENT] Add DMI collector #2131 * [ENHANCEMENT] Add threads metrics to processes collector #2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector #2169 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

Would emit (interface, addr, netmask, scope) labels for every network interface See prometheus/node_exporter#2105 This complements current bosh exporter support for a single IP address, see cloudfoundry/bosh_exporter#18

* add node_network_address_info collector emit (interface, addr, netmask, scope) labels for every network interface Signed-off-by: binjip978 <binjip978@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector prometheus#2146 * [CHANGE] Exclude filesystems under /run/credentials prometheus#2157 * [FEATURE] Add lnstat collector for metrics from /proc/net/stat/ prometheus#1771 * [FEATURE] Add darwin powersupply collector prometheus#1777 * [FEATURE] Add support for monitoring GPUs on Linux prometheus#1998 * [FEATURE] Add Darwin thermal collector prometheus#2032 * [FEATURE] Add os release collector prometheus#2094 * [FEATURE] Add netdev.address-info collector prometheus#2105 * [ENHANCEMENT] Support glob textfile collector directories prometheus#1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric prometheus#2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering prometheus#2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics prometheus#2123 * [ENHANCEMENT] Add DMI collector prometheus#2131 * [ENHANCEMENT] Add threads metrics to processes collector prometheus#2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector prometheus#2169 * [BUGFIX] ethtool: Sanitize metric names prometheus#2093 * [BUGFIX] Fix ethtool collector for multiple interfaces prometheus#2126 * [BUGFIX] Fix possible panic on macOS prometheus#2133 * [BUGFIX] Collect flag_info and bug_info only for one core prometheus#2156 Signed-off-by: Ben Kochie <superq@gmail.com>

* add node_network_address_info collector emit (interface, addr, netmask, scope) labels for every network interface Signed-off-by: binjip978 <binjip978@gmail.com>

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector prometheus#2146 * [CHANGE] Exclude filesystems under /run/credentials prometheus#2157 * [FEATURE] Add lnstat collector for metrics from /proc/net/stat/ prometheus#1771 * [FEATURE] Add darwin powersupply collector prometheus#1777 * [FEATURE] Add support for monitoring GPUs on Linux prometheus#1998 * [FEATURE] Add Darwin thermal collector prometheus#2032 * [FEATURE] Add os release collector prometheus#2094 * [FEATURE] Add netdev.address-info collector prometheus#2105 * [ENHANCEMENT] Support glob textfile collector directories prometheus#1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric prometheus#2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering prometheus#2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics prometheus#2123 * [ENHANCEMENT] Add DMI collector prometheus#2131 * [ENHANCEMENT] Add threads metrics to processes collector prometheus#2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector prometheus#2169 * [BUGFIX] ethtool: Sanitize metric names prometheus#2093 * [BUGFIX] Fix ethtool collector for multiple interfaces prometheus#2126 * [BUGFIX] Fix possible panic on macOS prometheus#2133 * [BUGFIX] Collect flag_info and bug_info only for one core prometheus#2156 Signed-off-by: Ben Kochie <superq@gmail.com>

add node_network_address collector

424de84

emit (interface, addr, netmask, scope) labels for every network interface Signed-off-by: binjip978 <binjip978@gmail.com>

binjip978 mentioned this pull request Jul 30, 2021

Add node_network_ipv4_address_info metric #1845

Closed

SuperQ reviewed Jul 30, 2021

View reviewed changes

collector/network_address.go Outdated Show resolved Hide resolved

move address-info metric to netdev_common

b8247e4

Signed-off-by: binjip978 <binjip978@gmail.com>

binjip978 requested a review from SuperQ August 6, 2021 09:00

rename addr to address

ed45981

Signed-off-by: binjip978 <binjip978@gmail.com>

rename entries to info

d5d44b6

Signed-off-by: binjip978 <binjip978@gmail.com>

SuperQ reviewed Sep 4, 2021

View reviewed changes

collector/netdev_common.go Show resolved Hide resolved

SuperQ requested a review from discordianfish September 4, 2021 15:29

discordianfish reviewed Sep 8, 2021

View reviewed changes

collector/netdev_common.go Show resolved Hide resolved

discordianfish approved these changes Sep 8, 2021

View reviewed changes

SuperQ approved these changes Sep 8, 2021

View reviewed changes

SuperQ merged commit a0c20d4 into prometheus:master Sep 8, 2021

binjip978 deleted the network-address-collector branch September 8, 2021 13:42

SuperQ mentioned this pull request Oct 11, 2021

Release 1.3.0 #2168

Merged

contrun mentioned this pull request Feb 16, 2022

nixos/prometheus: add AF_NETLINK permission to node-exporter netdev NixOS/nixpkgs#160292

Closed

13 tasks

gberche-orange mentioned this pull request Feb 7, 2024

Add support for netdev.address-info cloudfoundry/node-exporter-boshrelease#20

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

add node_network_address collector#2105

add node_network_address collector#2105
SuperQ merged 4 commits intoprometheus:masterfrom
binjip978:network-address-collector

binjip978 commented Jul 30, 2021

Uh oh!

Uh oh!

nathansgreen commented Sep 2, 2021

Uh oh!

binjip978 commented Sep 3, 2021

Uh oh!

discordianfish commented Sep 3, 2021

Uh oh!

SuperQ commented Sep 3, 2021

Uh oh!

Uh oh!

Uh oh!

discordianfish left a comment

Uh oh!

SuperQ left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

binjip978 commented Jul 30, 2021

Uh oh!

Uh oh!

nathansgreen commented Sep 2, 2021

Uh oh!

binjip978 commented Sep 3, 2021

Uh oh!

discordianfish commented Sep 3, 2021

Uh oh!

SuperQ commented Sep 3, 2021

Uh oh!

Uh oh!

Uh oh!

discordianfish left a comment

Choose a reason for hiding this comment

Uh oh!

SuperQ left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants