Release 1.3.0 by SuperQ · Pull Request #2168 · prometheus/node_exporter

SuperQ · 2021-10-11T20:14:13Z

NOTE: In order to support globs in the textfile collector path, filenames exposed by
node_textfile_mtime_seconds now contain the full path name.

[CHANGE] Add path label to rapl collector add path label to rapl collector #2146
[CHANGE] Exclude filesystems under /run/credentials Ignore mountpoints under /run #2157
[FEATURE] Add lnstat collector for metrics from /proc/net/stat/ Lnstat: expose metrics from /proc/net/stat #1771
[FEATURE] Add darwin powersupply collector darwin powersupply collector #1777
[FEATURE] Add support for monitoring GPUs on Linux Add initial support for monitoring GPUs on Linux #1998
[FEATURE] Add Darwin thermal collector feat: new collector about thermal conditions on macos #2032
[FEATURE] Add os release collector Add os release collector #2094
[FEATURE] Add netdev.address-info collector add node_network_address collector #2105
[ENHANCEMENT] Support glob textfile collector directories collector: Unwrap glob textfile directories #1985
[ENHANCEMENT] ethtool: Expose node_ethtool_info metric ethtool: Expose node_ethtool_info metric #2080
[ENHANCEMENT] Use include/exclude flags for ethtool filtering Use include/exclude flags for ethtool filtering #2165
[ENHANCEMENT] Add flag to disable guest CPU metrics Add flag to disable guest CPU metrics #2123
[ENHANCEMENT] Add DMI collector Add DMI collector #2131
[ENHANCEMENT] Add threads metrics to processes collector Support number of threads in each state #2164
[ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector Fix timer GC delays in the Linux filesystem collector #2169
[BUGFIX] ethtool: Sanitize metric names ethtool: Sanitize metric names #2093
[BUGFIX] Fix ethtool collector for multiple interfaces mod: update safchain/ethtool dependency. #2126
[BUGFIX] Fix possible panic on macOS Update github.com/lufia/iostat to v1.1.1 #2133
[BUGFIX] Collect flag_info and bug_info only for one core collect flag_info and bug_info only for one core #2156

Signed-off-by: Ben Kochie superq@gmail.com

roidelapluie

I just wonder if we should rename the os collector to os-release

CHANGELOG.md

SuperQ · 2021-10-12T15:20:36Z

@roidelapluie I was actually thinking about moving the os collector into the uname collector.

roidelapluie · 2021-10-12T15:51:30Z

@roidelapluie I was actually thinking about moving the os collector into the uname collector.

either way is fine, however it is not really uname and it could confuse users. We could merge osrelease and uname in a unique os collector.

discordianfish · 2021-10-13T16:37:12Z

+1 for merging os and uname into a os collector.

discordianfish · 2021-10-28T15:22:18Z

We should make sure these are fixed before releasing:

ventifus · 2021-10-28T18:20:08Z

We are good on #2185, we currently have enough tools to work around the issue there.

bdrung · 2021-10-29T08:51:46Z

This pull request misses to mention the new collector: Lnstat: expose metrics from /proc/net/stat (#1771)

CHANGELOG.md

hodgesds · 2021-11-01T00:55:36Z

I'd really like to sneak #2190 in if possible.

yeganeahmadnejad · 2021-11-06T19:39:46Z

when it's going to be released ?

discordianfish · 2021-11-15T09:55:59Z

@SuperQ Can we include the clocksource change?

[FEATURE] Add clocksource info metrics to time collector on linux Add clocksource metrics to time collector #2197

SuperQ · 2021-11-15T15:32:42Z

@discordianfish Yup, now that we have the additional ethtool fixes in, I'll sync everything up and ping you for review.

bdrung · 2021-11-15T15:34:53Z

Can we also have #2188 in the release?

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector #2146 * [CHANGE] Exclude filesystems under /run/credentials #2157 * [FEATURE] Add lnstat collector for metrics from /proc/net/stat/ #1771 * [FEATURE] Add darwin powersupply collector #1777 * [FEATURE] Add support for monitoring GPUs on Linux #1998 * [FEATURE] Add Darwin thermal collector #2032 * [FEATURE] Add os release collector #2094 * [FEATURE] Add netdev.address-info collector #2105 * [ENHANCEMENT] Support glob textfile collector directories #1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric #2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering #2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics #2123 * [ENHANCEMENT] Add DMI collector #2131 * [ENHANCEMENT] Add threads metrics to processes collector #2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector #2169 * [BUGFIX] ethtool: Sanitize metric names #2093 * [BUGFIX] Fix ethtool collector for multiple interfaces #2126 * [BUGFIX] Fix possible panic on macOS #2133 * [BUGFIX] Collect flag_info and bug_info only for one core #2156 Signed-off-by: Ben Kochie <superq@gmail.com>

SuperQ · 2021-11-18T08:44:41Z

Ok, I think we're ready to go. Everyone please review for final release.

bdrung · 2021-11-18T09:21:17Z

Looks good from my side.

roidelapluie

Thanks!

discordianfish

LGTM 🚀

NOTE: In order to support globs in the textfile collector path, filenames exposed by `node_textfile_mtime_seconds` now contain the full path name. * [CHANGE] Add path label to rapl collector prometheus#2146 * [CHANGE] Exclude filesystems under /run/credentials prometheus#2157 * [FEATURE] Add lnstat collector for metrics from /proc/net/stat/ prometheus#1771 * [FEATURE] Add darwin powersupply collector prometheus#1777 * [FEATURE] Add support for monitoring GPUs on Linux prometheus#1998 * [FEATURE] Add Darwin thermal collector prometheus#2032 * [FEATURE] Add os release collector prometheus#2094 * [FEATURE] Add netdev.address-info collector prometheus#2105 * [ENHANCEMENT] Support glob textfile collector directories prometheus#1985 * [ENHANCEMENT] ethtool: Expose node_ethtool_info metric prometheus#2080 * [ENHANCEMENT] Use include/exclude flags for ethtool filtering prometheus#2165 * [ENHANCEMENT] Add flag to disable guest CPU metrics prometheus#2123 * [ENHANCEMENT] Add DMI collector prometheus#2131 * [ENHANCEMENT] Add threads metrics to processes collector prometheus#2164 * [ENHANCMMENT] Reduce timer GC delays in the Linux filesystem collector prometheus#2169 * [BUGFIX] ethtool: Sanitize metric names prometheus#2093 * [BUGFIX] Fix ethtool collector for multiple interfaces prometheus#2126 * [BUGFIX] Fix possible panic on macOS prometheus#2133 * [BUGFIX] Collect flag_info and bug_info only for one core prometheus#2156 Signed-off-by: Ben Kochie <superq@gmail.com>

frittentheke mentioned this pull request Oct 12, 2021

request for release 1.2.3 #2132

Closed

roidelapluie approved these changes Oct 12, 2021

View reviewed changes

roidelapluie reviewed Oct 12, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

SuperQ force-pushed the superq/1.3.0 branch from 7c6ae80 to 3bcb00a Compare October 12, 2021 15:22

SuperQ force-pushed the superq/1.3.0 branch 3 times, most recently from e8fe4d5 to 0da795a Compare October 19, 2021 10:10

SuperQ force-pushed the superq/1.3.0 branch 4 times, most recently from 0c997d5 to 1fb2dc5 Compare October 27, 2021 12:16

SuperQ marked this pull request as ready for review October 27, 2021 12:31

SuperQ requested a review from discordianfish October 27, 2021 12:31

SuperQ mentioned this pull request Oct 27, 2021

[BROKEN MASTER] Fix imports when building on MacOS #2180

Merged

nolith mentioned this pull request Oct 28, 2021

darwin powersupply collector #1777

Merged

SuperQ force-pushed the superq/1.3.0 branch from 1fb2dc5 to 1321b47 Compare October 28, 2021 08:23

ventifus mentioned this pull request Oct 28, 2021

ethtool error: "panic: "node_ethtool_ err" is not a valid metric name" #2185

Closed

SuperQ force-pushed the superq/1.3.0 branch from 1321b47 to 558c17b Compare October 29, 2021 09:02

bdrung reviewed Oct 29, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

SuperQ force-pushed the superq/1.3.0 branch from 558c17b to 33efb9a Compare November 18, 2021 08:44

SuperQ requested a review from roidelapluie November 18, 2021 08:44

roidelapluie approved these changes Nov 18, 2021

View reviewed changes

discordianfish approved these changes Nov 18, 2021

View reviewed changes

SuperQ merged commit c65f870 into master Nov 18, 2021

SuperQ deleted the superq/1.3.0 branch November 18, 2021 15:11

nuclearpidgeon mentioned this pull request Mar 27, 2024

Add node_network_ipv4_address_info metric #1845

Closed

Comments

Conversation

SuperQ commented Oct 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roidelapluie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SuperQ commented Oct 12, 2021

Uh oh!

roidelapluie commented Oct 12, 2021

Uh oh!

discordianfish commented Oct 13, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

discordianfish commented Oct 28, 2021

Uh oh!

ventifus commented Oct 28, 2021

Uh oh!

bdrung commented Oct 29, 2021

Uh oh!

Uh oh!

hodgesds commented Nov 1, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yeganeahmadnejad commented Nov 6, 2021

Uh oh!

discordianfish commented Nov 15, 2021

Uh oh!

SuperQ commented Nov 15, 2021

Uh oh!

bdrung commented Nov 15, 2021

Uh oh!

SuperQ commented Nov 18, 2021

Uh oh!

bdrung commented Nov 18, 2021

Uh oh!

roidelapluie left a comment

Choose a reason for hiding this comment

Uh oh!

discordianfish left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

SuperQ commented Oct 11, 2021 •

edited

Loading

discordianfish commented Oct 13, 2021 •

edited

Loading

hodgesds commented Nov 1, 2021 •

edited

Loading