Add clocksource metrics to time collector#2197
Merged
discordianfish merged 4 commits intomasterfrom Nov 12, 2021
Merged
Conversation
discordianfish
force-pushed
the
add-clocksource-collector
branch
4 times, most recently
from
ff8d354 to
9c5646a
Compare
roidelapluie
reviewed
Nov 5, 2021
Member
|
Hmm, how weird would this be to put in the |
discordianfish
force-pushed
the
add-clocksource-collector
branch
from
9c5646a to
3e3e721
Compare
Member
Author
|
@roidelapluie Thanks, fixed! @SuperQ Copying my response from chat for reference:
Yeah was considering that as well but ended up with a standalone collector since timex might require --cap-add=SYS_TIME But lemme know, I'm fine either way. |
This closes #1336 Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
discordianfish
force-pushed
the
add-clocksource-collector
branch
from
3e3e721 to
c368a01
Compare
discordianfish
changed the title
discordianfish
force-pushed
the
add-clocksource-collector
branch
from
9bbc9da to
06a998b
Compare
Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
discordianfish
force-pushed
the
add-clocksource-collector
branch
from
06a998b to
294119e
Compare
SuperQ
requested changes
Nov 10, 2021
discordianfish
force-pushed
the
add-clocksource-collector
branch
2 times, most recently
from
36d6586 to
0a86bea
Compare
Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
discordianfish
force-pushed
the
add-clocksource-collector
branch
from
0a86bea to
d48ea72
Compare
We can't declare sysfs in time.go since the sysfs package itself is linux only. Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
discordianfish
force-pushed
the
add-clocksource-collector
branch
from
ab00063 to
32c520c
Compare
Merged
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Add clocksource metrics to time collector This closes prometheus#1336 Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
* Add clocksource metrics to time collector This closes prometheus#1336 Signed-off-by: Johannes 'fish' Ziemke <github@freigeist.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Straight forward implementation of #1336
One thing I'm not sure about is the 'device' label. Looks like in
/sys/devices/system/clocksourcethere are 'clocksource sources'. Each of the clocksource source has 'available_clocksource' and 'current_clocksource'.All systems I've checked only have
/sys/devices/system/clocksource/clocksource0, so dunno if multiple 'clocksource sources' even exists.@pgier since you implemented prometheus/procfs#154, maybe you have some opinions on this?