Skip to content

Comments

sysfs: add parsing of clocksource#154

Merged
discordianfish merged 2 commits intoprometheus:masterfrom
pgier:add-clocksource
May 19, 2019
Merged

sysfs: add parsing of clocksource#154
discordianfish merged 2 commits intoprometheus:masterfrom
pgier:add-clocksource

Conversation

@pgier
Copy link
Collaborator

@pgier pgier commented May 7, 2019

Read current and available clocksource data from
/sys/devices/system/clocksource

Related to prometheus/node_exporter#1336

Read current and available clocksource data from
/sys/devices/system/clocksource

Signed-off-by: Paul Gier <pgier@redhat.com>
@discordianfish
Copy link
Member

But LGTM beside the naming.

Following new naming conventions and remove top level functions.
Change 'Clocksource' to 'ClockSource' because most docs seem to
treat this as two words.

Signed-off-by: Paul Gier <pgier@redhat.com>
@pgier pgier requested a review from discordianfish May 17, 2019 14:00
@pgier
Copy link
Collaborator Author

pgier commented May 17, 2019

@discordianfish Does this look ok now?

@discordianfish discordianfish merged commit 54c388d into prometheus:master May 19, 2019
@discordianfish
Copy link
Member

Great, LGTM!

remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
* sysfs: add parsing of clocksource

Read current and available clocksource data from
/sys/devices/system/clocksource

Signed-off-by: Paul Gier <pgier@redhat.com>

* sysfs: update clocksource to follow naming conventions

Following new naming conventions and remove top level functions.
Change 'Clocksource' to 'ClockSource' because most docs seem to
treat this as two words.

Signed-off-by: Paul Gier <pgier@redhat.com>
bobrik pushed a commit to bobrik/procfs that referenced this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants