Skip to content

Comments

Add runit service dir flag#375

Merged
SuperQ merged 1 commit intomasterfrom
fish-add-runit-servicedir-flag
Dec 26, 2016
Merged

Add runit service dir flag#375
SuperQ merged 1 commit intomasterfrom
fish-add-runit-servicedir-flag

Conversation

@discordianfish
Copy link
Member

This closes #362

While the runit collect probably will get deprecated soon, this should have had a flag from day 1 so I think it's fair to add this for now.

@discordianfish
Copy link
Member Author

Closing this for now, this will be part of the supervisor_exporter though.

@discordianfish
Copy link
Member Author

Since it looks like we won't deprecate the supervisor collectors, this should get merged after all.

@discordianfish discordianfish added this to the v0.14.0 milestone Dec 22, 2016
@discordianfish
Copy link
Member Author

@SuperQ Ping

@SuperQ SuperQ merged commit 10e525f into master Dec 26, 2016
@SuperQ SuperQ deleted the fish-add-runit-servicedir-flag branch December 26, 2016 12:01
)

var runitServiceDir = flag.String(
"collector.runit.servicecdir",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably this is a typo: "servicecdir"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Will fix

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo is still present in v0.14.0-rc.1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whup, forgot that one!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed the fix to master, will show up in the final release.

@SuperQ SuperQ mentioned this pull request Jan 15, 2017
tamcore pushed a commit to gitgrave/node_exporter that referenced this pull request Oct 22, 2024
Add RSSLimit, rt_priority, policy and delay_acct_block to pid/stat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Getting user-specific services metrics from runit collector.

4 participants