Run java aarch64 tests on the CI (with an emulator)#8485
Conversation
jtattermusch
force-pushed
the
run_java_aarch64_test
branch
from
cfc7d91 to
66cb4fb
Compare
|
@dlj-NaN please review or assign to the right reviewer for protobuf java. |
jtattermusch
changed the title
fowles
left a comment
fowles
left a comment
There was a problem hiding this comment.
pzd has been working on java tests lately. Please wait for his review
| # create a simple shell wrapper that runs crosscompiled protoc under qemu | ||
| echo '#!/bin/bash' >protoc_qemu_wrapper.sh | ||
| echo 'exec qemu-aarch64 "../src/protoc" "$@"' >>protoc_qemu_wrapper.sh | ||
| chmod ugo+x protoc_qemu_wrapper.sh |
There was a problem hiding this comment.
pull request says java, but this was also part of your python PR...
There was a problem hiding this comment.
It's rebased now (this PR depended on some files introduced by they python PR).
| set -ex | ||
|
|
||
| # Change to repo root | ||
| cd $(dirname $0)/../../.. |
There was a problem hiding this comment.
cd $(git rev-parse --show-toplevel)
seems more reliable than counting directories
There was a problem hiding this comment.
Let's leave as is as this is the "standard" way it's currently done in most protobuf's CI testing scripts.
I think it's better to stay consistent with the way it's done in most places in this repository.
Examples:
https://github.com/protocolbuffers/protobuf/blob/3f5fc4df1de8e12b2235c3006593e22d6993c3f5/kokoro/release/python/linux/build_artifacts.sh
https://github.com/protocolbuffers/protobuf/blob/3f5fc4df1de8e12b2235c3006593e22d6993c3f5/kokoro/release/protoc/linux/build.sh
https://github.com/protocolbuffers/protobuf/blob/3f5fc4df1de8e12b2235c3006593e22d6993c3f5/kokoro/linux/benchmark/run.sh
jtattermusch
force-pushed
the
run_java_aarch64_test
branch
from
66cb4fb to
b284bee
Compare
jtattermusch
left a comment
jtattermusch
left a comment
There was a problem hiding this comment.
I rebased the PR after merging the python PR, so now the stuff to review is only java related.
| set -ex | ||
|
|
||
| # Change to repo root | ||
| cd $(dirname $0)/../../.. |
There was a problem hiding this comment.
Let's leave as is as this is the "standard" way it's currently done in most protobuf's CI testing scripts.
I think it's better to stay consistent with the way it's done in most places in this repository.
Examples:
https://github.com/protocolbuffers/protobuf/blob/3f5fc4df1de8e12b2235c3006593e22d6993c3f5/kokoro/release/python/linux/build_artifacts.sh
https://github.com/protocolbuffers/protobuf/blob/3f5fc4df1de8e12b2235c3006593e22d6993c3f5/kokoro/release/protoc/linux/build.sh
https://github.com/protocolbuffers/protobuf/blob/3f5fc4df1de8e12b2235c3006593e22d6993c3f5/kokoro/linux/benchmark/run.sh
|
@perezd please review so we can merge this soon. |
5 participants
Based on #8479 (only the last few commits need to be reviewed).
Example passing adhoc run: http://sponge2.corp.google.com/95eaabd8-a929-4dfd-839a-4b4bef078391