Run ruby aarch64 tests on the CI (with an emulator)#8495
Merged
jtattermusch merged 3 commits intoApr 26, 2021
Conversation
Contributor
Author
|
@dlj-NaN please review or reassign to protobuf ruby owner. |
fowles
reviewed
Apr 22, 2021
Contributor
fowles
left a comment
fowles
left a comment
There was a problem hiding this comment.
this appears to include both java and python as part of this. Please update these to be separate or commit earlier ones before pushing follow ons
Contributor
|
Josh, you can wait for jtattermusch to separate the change a bit before reviewing |
jtattermusch
force-pushed
the
run_ruby_aarch64_test
branch
from
dc2c831 to
7c87692
Compare
Contributor
Author
fowles
approved these changes
Apr 24, 2021
Contributor
Author
|
@haberman is this ok to merge? |
haberman
approved these changes
Apr 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #8485 (only the few last commits are ruby related).
Ruby's native build is very simple (it only compiles a few .c files), so running ruby's build directly under an emulator is the simplest solution and it's quick enough. Only the protoc binaries get crosscompiled since building protoc under an emulator would be slow.