Update BoringSSL to 2023-08-28.

[martijneken]

Fixes build warning-as-error:

external/boringssl/src/crypto/x509/t_x509.c:326:18: error: variable 'l' set but not used [-Werror,-Wunused-but-set-variable]
    int ret = 0, l, i;
                 ^

[martijneken]

• macOS build failures are known issue [CI] macOS builds: "AttributeError: module 'pkgutil' has no attribute 'ImpImporter'. Did you mean: 'zipimporter'?" #384
• cargo-raze failure is being worked on in [WIP] repo: Shift cargo-raze -> crate_universe #390

[martijneken]

Friendly ping @PiotrSikora

[PiotrSikora]

LGTM, but those should be 2 separate PRs.

[martijneken]

LGTM, but those should be 2 separate PRs.

Sorry, not sure what you mean, this is a minimal PR. I think you're talking about macOS and cargo-raze issues? Yes, those are being addressed separately. Can we get this merged despite the pre-existing CI issues?

Or if you're talking about the buildifier fix, that was a presubmit identified issue and fixing it is trivial and safe.

[PiotrSikora]

Or if you're talking about the buildifier fix, that was a presubmit identified issue and fixing it is trivial and safe.

This. I agree that it's trivial and safe, but there is no reason to bundle those 2 unrelated changes into a single PR.

[martijneken]

Split the BUILD fix to #394, PTAL @PiotrSikora

[PiotrSikora]

LGTM, although the fact that we're updating to a version from 8 months ago is a bit questionable.

[PiotrSikora]

@martijneken sorry, I keep forgetting that for some reason GitHub decides to use my old @google.com email address in UI-triggered merge commits... Could you rebase this on top of master and drop my merge commit? Thanks!

[martijneken]

@PiotrSikora I'm confused why your review is not considered a sufficient Code Owner review. Maybe because you added a merge commit? BTW this triggered a CLA check issue -- are you able to resolve that?

[PiotrSikora]

@PiotrSikora I'm confused why your review is not considered a sufficient Code Owner review. Maybe because you added a merge commit?

That's not it, see: #392 (comment)

BTW this triggered a CLA check issue -- are you able to resolve that?

Done... But could you merge the master branch to enable merge?