Skip to content

fix: buildifier complaint#394

Merged
martijneken merged 2 commits intoproxy-wasm:masterfrom
martijneken:buildifier-fix
Apr 29, 2024
Merged

fix: buildifier complaint#394
martijneken merged 2 commits intoproxy-wasm:masterfrom
martijneken:buildifier-fix

Conversation

@martijneken
Copy link
Contributor

No description provided.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Contributor Author

Seems like the code owner review is sticky to the randomly assigned reviewer. Would this be more flexible if we used a group, e.g. the maintainers group? https://github.com/orgs/proxy-wasm/teams/maintainers-c

@PiotrSikora
Copy link
Member

Seems like the code owner review is sticky to the randomly assigned reviewer. Would this be more flexible if we used a group, e.g. the maintainers group? https://github.com/orgs/proxy-wasm/teams/maintainers-c

That's not it, see: #392 (comment)

@martijneken martijneken merged commit 265e9d8 into proxy-wasm:master Apr 29, 2024
@martijneken martijneken deleted the buildifier-fix branch April 29, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants