Skip to content

Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes #149.#150

Closed
martijneken wants to merge 4 commits intoproxy-wasm:masterfrom
martijneken:emsdk-3.1.7-patch
Closed

Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes #149.#150
martijneken wants to merge 4 commits intoproxy-wasm:masterfrom
martijneken:emsdk-3.1.7-patch

Conversation

@martijneken
Copy link
Copy Markdown
Contributor

No description provided.

…sm#149.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@PiotrSikora
Copy link
Copy Markdown
Member

Sigh, it looks that clang-format-9 is no longer available in Ubuntu packages. Could you update it to fix the CI?

Also, could you add a daily CI run on schedule to catch those regressions when they happen (see: https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/94497deb683e37c0fc54e252b600de1dd4d47406/.github/workflows/test.yml#L31-L32)?

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Copy Markdown
Contributor Author

Updated CI to use recent clang-format and run daily. PTAL.

@martijneken
Copy link
Copy Markdown
Contributor Author

Looking at what's going on with addlicense.

@martijneken
Copy link
Copy Markdown
Contributor Author

Looking at what's going on with addlicense.

addlicense wants me to add this to every BUILD file. Is that desired?

+# Copyright 2023 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.

@martijneken
Copy link
Copy Markdown
Contributor Author

Probably due to google/addlicense#127

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Copy Markdown
Contributor Author

Removed BUILD files from addlicense check for now.

Copy link
Copy Markdown
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicking, but could you split unrelated fixes into a separate PR? Thanks!

@martijneken
Copy link
Copy Markdown
Contributor Author

Sent #151 and #152. Couldn't figure out how to stack PRs.

@martijneken martijneken deleted the emsdk-3.1.7-patch branch April 29, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants