Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes #149.#150
Patch from Envoy: exclude emsdk targets for Bazel/gcc. Fixes #149.#150martijneken wants to merge 4 commits intoproxy-wasm:masterfrom
Conversation
…sm#149. Signed-off-by: Martijn Stevenson <mstevenson@google.com>
|
Sigh, it looks that Also, could you add a daily CI run on schedule to catch those regressions when they happen (see: https://github.com/proxy-wasm/proxy-wasm-cpp-host/blob/94497deb683e37c0fc54e252b600de1dd4d47406/.github/workflows/test.yml#L31-L32)? |
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
|
Updated CI to use recent clang-format and run daily. PTAL. |
|
Looking at what's going on with addlicense. |
addlicense wants me to add this to every BUILD file. Is that desired? |
|
Probably due to google/addlicense#127 |
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
|
Removed BUILD files from addlicense check for now. |
PiotrSikora
left a comment
There was a problem hiding this comment.
Nitpicking, but could you split unrelated fixes into a separate PR? Thanks!
No description provided.