Skip to content

Fix the CI.#151

Merged
mpwarres merged 4 commits intoproxy-wasm:masterfrom
martijneken:fix-cpp-sdk-ci
Apr 29, 2023
Merged

Fix the CI.#151
mpwarres merged 4 commits intoproxy-wasm:masterfrom
martijneken:fix-cpp-sdk-ci

Conversation

@martijneken
Copy link
Copy Markdown
Contributor

@martijneken martijneken commented Apr 27, 2023

No description provided.

@martijneken
Bump clang-format version to work on ubuntu-latest
9188de7 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Add daily CI run for proxy-wasm-cpp-sdk
f8a7344 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Ignore BUILD files in license checks
d6e53b4 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
This was referenced Apr 27, 2023
Merged
Closed
PiotrSikora
PiotrSikora reviewed Apr 27, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change ubuntu-latest to ubuntu-22.04 to avoid base image change silently breaking this in the future?

@martijneken
Use known CI platform: ubuntu-latest to ubuntu-22.04
fab8b5e 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Copy link
Copy Markdown
Contributor Author

martijneken commented Apr 27, 2023

Could you change ubuntu-latest to ubuntu-22.04 to avoid base image change silently breaking this in the future?

Done, PTAL.

@martijneken
Copy link
Copy Markdown
Contributor Author

martijneken commented Apr 28, 2023

Can we auto-run testing workflows in this repo? Seems like proxy-wasm-cpp-host does that.

PiotrSikora
PiotrSikora approved these changes Apr 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PiotrSikora PiotrSikora changed the title Fix proxy-wasm-cpp-sdk CI Fix the CI. Apr 28, 2023
@PiotrSikora
Copy link
Copy Markdown
Member

PiotrSikora commented Apr 28, 2023

@mpwarres could you merge it? It looks that I don't have the permission to do that in this repo anymore.

@PiotrSikora
Copy link
Copy Markdown
Member

PiotrSikora commented Apr 28, 2023

Can we auto-run testing workflows in this repo? Seems like proxy-wasm-cpp-host does that.

They are executed automatically, but only for people who contributed previously (this is a GitHub-wide policy to prevent abuse). Once this PR is merged, your other changes will trigger CI automatically.

@mpwarres mpwarres merged commit 97de5ab into proxy-wasm:master Apr 29, 2023
@martijneken martijneken deleted the fix-cpp-sdk-ci branch April 29, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@martijneken @PiotrSikora @mpwarres