(🎁) String processing: re-enable wrap concatenated strings in parens in all cases

[KotlinIsland]

input:

f(
    "lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor" 
    "incididunt ut labore et dolore magna aliqua Ut enim ad minim",
    "",
)

Expected output:

f(
    (
        "lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor" 
        "incididunt ut labore et dolore magna aliqua Ut enim ad minim"
    ),
    "",
)

Actual:

No change

Playground

playground

Context:

This was implemented and reverted due to disruptive changes:

f(
    x,
-   "lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor" 
-   "incididunt ut labore et dolore magna aliqua Ut enim ad minim",
+   (
+       "lorem ipsum dolor sit amet consectetur adipiscing elit sed do eiusmod tempor" 
+       "incididunt ut labore et dolore magna aliqua Ut enim ad minim"
+   ),
)

I think that it should be re-enabled, because it does improve style, readability, and catch bugs. Some additional cases should be considered:

• Only wrap the string if it shares a boundary with an expression that starts with a string literal:

Details

f(
    x,
    "a"  # don't wrap
    "b",
)

f(
    "a"  # don't wrap
    "b",
    x,
)

f(
    1,
    "a"  # don't wrap
    "b",
)

f(
    "a" + "b",
    "a"  # wrap, the preceding parameter begins with a string literal
    "b",
)

• Don't wrap in cases of following keyword arguments:

Details

f(
    "a"  # don't wrap
    "b",
    a="a",
)

f(
    "a",
    a="a"  # don't wrap
    "b",
)

f(
    a="a",
    "a"  # wrap
    "b",
)

f(
    a="a"  # wrap
    "b",
    "a",
)

I feel like this is a healthy balance of disruption and readability.

Related:

• String processing: wrap concatenated strings in parens in all cases #3292
• Wrap concatenated strings used as function args in parens. #3307
• Do not wrap implicitly concatenated strings used as func args in parens. #3640

Black version 23.10.0