Wrap concatenated strings used as function args in parens.#3307
Merged
Conversation
Contributor
|
diff-shades results comparing this PR (5f4e810) to main (09d4acd). The full diff is available in the logs under the "Generate HTML diff report" step. |
Collaborator
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looking at the diff-shades output I'm still a bit nervous whether this is a net positive, since it does often feel like it's adding unnecessary lines. But I guess that's what we have a preview style for.
Contributor
Author
|
Updated, please take another look. Thanks Jelle! |
JelleZijlstra
approved these changes
Oct 27, 2022
copybara-service Bot
pushed a commit
to google/pyink
that referenced
this pull request
Dec 19, 2022
…l" section. psf#3307 is merged. PiperOrigin-RevId: 496442325
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements #3292.
I have only heard one 👍 from @felix-hilden. But I think it's also easier to decide after seeing the formatting changes introduced by this PR, thus I'm sending it now so we can visualize the diffs.
Checklist - did you ...
CHANGES.mdif necessary?