Skip to content

Systolic execution on MemPool#34

Merged
SamuelRiedel merged 57 commits intomainfrom
systolic-matmul
Apr 26, 2022
Merged

Systolic execution on MemPool#34
SamuelRiedel merged 57 commits intomainfrom
systolic-matmul

Conversation

@SamuelRiedel
Copy link
Contributor

@SamuelRiedel SamuelRiedel commented Mar 29, 2022 •
edited
Loading

Add a first step towards executing systolic applications in a systolic fashion in MemPool. This adds a new systolic configuration of MemPool, including runtime support and a matrix multiplication emulating systolic operation on MemPool via a software layer.

Changelog

Added

  • Add a systolic configuration including runtime support and a matmul application

(Reference to issues, labels, and related merge requests)

Checklist

  • Automated tests pass
  • Changelog updated
  • Code style guideline is observed

Please check our contributing guidelines before opening a Pull Request.

@SamuelRiedel SamuelRiedel marked this pull request as ready for review March 30, 2022 07:14
khovg and others added 27 commits April 1, 2022 15:41
@khovg @SamuelRiedel
[apps] Add preliminary queue
c60d938
@khovg @SamuelRiedel
[apps] Add malloc implementation
87034ac
@khovg @SamuelRiedel
[apps] Extend test of allocator
f0fc37b
@khovg @SamuelRiedel
[apps] Adjust queue.* to work with malloc.*
1ebc664
@khovg @SamuelRiedel
[apps] Extend queue functionality (delete, blocking and counting)
c5925c3
@khovg @SamuelRiedel
[apps] Add delete to queue test
8a44636
@SamuelRiedel
[software] Adapt allocator test to new runtime
7d64213
@SamuelRiedel
[software] Fix license headers
4b646a8
@khovg @SamuelRiedel
[apps] Add systolic matrix mult foundation
7bdd86c
@khovg @SamuelRiedel
[apps] Implement systolic matrix mult based on custom matrix represen…
fc32d9a 
…tation
@khovg @SamuelRiedel
[apps] Remove pre-fill from outer CCs and RCs
8af3294
@khovg @SamuelRiedel
[apps] Fix data copy to systolic matrix
c863d65
@khovg @SamuelRiedel
[apps] Fix too large grid size of systolic queues
975ad63
@khovg @SamuelRiedel
[apps] Add allocation debugging info to systolic matrix mult test
017dbf9
@khovg @SamuelRiedel
[apps] Fix systolic queue assignment for processing elements
2219879
@khovg @SamuelRiedel
[apps] Fix cores at grid boundary and end instruction
9d2cde7
@khovg @SamuelRiedel
[apps] Improve systolic matrix print
74f9b7e
@khovg @SamuelRiedel
[apps] Fix systolic_matrix_create() for non-multiple matrices
13a78d2
@khovg @SamuelRiedel
[apps] Adjust counting queue operations
95c1629
@khovg @SamuelRiedel
[apps] Add address pointers
abf58eb
@khovg @SamuelRiedel
[apps] Adjust counting queues for benchmark
3edddd0
@khovg @SamuelRiedel
[apps] Add invasive benchmarking to systolic matrix mult
3e968cb
@khovg @SamuelRiedel
[apps] Prevent optimization of empty while loop in queue operations
5336afd
@khovg @SamuelRiedel
[apps] Reduce printf in systolic matrix mult
a0f4c8c
@khovg @SamuelRiedel
[apps] Move initialization to runtime.h
61e4616
@khovg @SamuelRiedel
[apps] Improve PE systolic loop throughput
cfaf117
@SamuelRiedel
[software] Restructure systolic apps and runtime
5e129bf
@SamuelRiedel
Copy link
Contributor Author

SamuelRiedel commented Apr 21, 2022

Thanks for the review. I implemented your suggestions. Let me know what you think.

@SamuelRiedel SamuelRiedel requested a review from suehtamacv April 21, 2022 16:15
suehtamacv
suehtamacv approved these changes Apr 26, 2022
View reviewed changes
khovg and others added 22 commits April 26, 2022 11:25
@khovg @SamuelRiedel
[apps] Add parametrized sequential memory region with reserved region…
8afd5f5 
… for queues
@khovg @SamuelRiedel
[hardware] Add queue size parameter from config
93276b2
@SamuelRiedel
[config] Add systolic configuration
4981e20
@SamuelRiedel
[software] Adapt systolic matmul to new runtime
14f9545
@SamuelRiedel
[software] Initialize performance counters in systolic matmul
8f51ab0
@khovg @SamuelRiedel
[apps] Add queue kernel with multi push/pop based on counter
aa6e0c5
@khovg @SamuelRiedel
[apps] Fix queue.h and queue_multi.h with volatile
47e7dd9
@khovg @SamuelRiedel
[apps] Extend queue tests
a3a795b
@khovg @SamuelRiedel
[apps] Change to pre-defined size queues in queue_multi.h
efd6289
@khovg @SamuelRiedel
[apps] Change systolic matmul to use multiple elements per push/pop
646115b
@khovg @SamuelRiedel
[apps] Use 2x2 tiles for systolic matmul
63fa7d3
@khovg @SamuelRiedel
[apps] Fix systolic matmul's dummy push/pop
46cdb2e
@khovg @SamuelRiedel
[apps] Simplify systolic_matrix in systolic_d to zero-padded matrix
716e62c
@khovg @SamuelRiedel
[apps] Remove redundant sub_matrix_dim define
fed8065
@SamuelRiedel
[apps] Adjust systolic matmul to use CSR dump for benchmarks
af3bbaf
@khovg @SamuelRiedel
[apps] Add extended benchmark version of systolic_d
3c3419f
@SamuelRiedel
Revert "[apps] Add extended benchmark version of systolic_d"
af09375 
This reverts commit ee5dd8be827c02ffb83d3e146854a409a5445245.
@SamuelRiedel
[software] Clean up final systolic matrix multiplication
650c2e1
@SamuelRiedel
[CHANGELOG] Add a systolic matrix multiplication
f4ab05c
@SamuelRiedel
[software] Clean up the stack calculation
ed851bf 
Make the stack calculation configurable
@SamuelRiedel
[software] Exclude systolic apps for non-systolic configurations
2275773
@SamuelRiedel
[software] Clarify allocation in sequential region
c9a4880
@SamuelRiedel SamuelRiedel merged commit eb99b6a into main Apr 26, 2022
@SamuelRiedel SamuelRiedel deleted the systolic-matmul branch April 26, 2022 10:36
@sermazz sermazz mentioned this pull request Aug 18, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@suehtamacv suehtamacv suehtamacv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamuelRiedel @suehtamacv @khovg