Parametrization fixes to systolic queues software implementation#57
Merged
SamuelRiedel merged 3 commits intomainfrom Sep 14, 2022
Merged
Parametrization fixes to systolic queues software implementation#57SamuelRiedel merged 3 commits intomainfrom
SamuelRiedel merged 3 commits intomainfrom
Conversation
d37af9c to
c6c1b3d
Compare
Contributor
SamuelRiedel
left a comment
There was a problem hiding this comment.
Thanks a lot Sergio. I added a few explanations. If you want to fix them, go ahead. Otherwise, this looks good to me :) Please rebase and fix the one small linting error.
7615f63 to
b05a978
Compare
b05a978 to
68a9fbd
Compare
ada0dee to
dfacf4d
Compare
Collaborator
Author
All done; can be merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix parametrization of runtime functions (including memory allocation, queue management library, systolic matmul library) and systolic queue software examples. These fixes add on top of #34, making the systolic software implementation more readable and self-explanatory.
Changelog
in:
Checklist
Future improvement
DATA_SIZE == 4 && NUM_CORES == 256alloc.cruntime.h:mempool_init()