Conversation
Contributor
Author
|
I have opened two PRs also in the runtime and regression tests. |
Contributor
|
I was able to build the design and run the test out of the box. As a plus, I could rebase my branch with the fault injection scripts on top of this branch to perform fault injection in the memory and test the behavior of the scrubber. |
ricted98
reviewed
Feb 28, 2024
ricted98
reviewed
Feb 28, 2024
micprog
requested changes
Feb 28, 2024
Contributor
Author
|
@micprog I should have addressed all the changes you requested, do you think the comments could be resolved? |
Contributor
Author
|
Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.