Skip to content

Comments

Integrate fault injection flow#56

Merged
yvantor merged 6 commits intoastralfrom
rt/fault-injection-rebase
Mar 13, 2024
Merged

Integrate fault injection flow#56
yvantor merged 6 commits intoastralfrom
rt/fault-injection-rebase

Conversation

@ricted98
Copy link
Contributor

@ricted98 ricted98 commented Feb 29, 2024

Add a fault injection flow support in the PULP cluster.

In particular, the TCL scripts used to run the simulation look for env variables named FAULT_INJECTION to toggle fault injection and FAULT_INJECTION_SCRIPT to source the top level script responsible for invoking all the different subroutines for the fault injection.

This draft PR is subordinate to the merge of #54 and can be considered a WIP.

@ricted98 ricted98 requested review from micprog and yvantor February 29, 2024 08:12
@ricted98 ricted98 force-pushed the rt/fault-injection-rebase branch from d7b423c to 5680405 Compare February 29, 2024 08:20
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far OK, but I think this is still WIP (I see it marked as draft).

@ricted98 ricted98 force-pushed the rt/fault-injection-rebase branch 2 times, most recently from 9bb3e25 to 54be025 Compare March 1, 2024 08:47
@ricted98
Copy link
Contributor Author

ricted98 commented Mar 1, 2024

Force pushed to rebase it on astral. I believe in a short time I will convert this PR from draft to review-ready.

@ricted98 ricted98 marked this pull request as ready for review March 6, 2024 16:05
Copy link
Contributor

@yvantor yvantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one additional comment, other than that it looks good!

@ricted98
Copy link
Contributor Author

ricted98 commented Mar 8, 2024

This PR is paired to pulp-platform/regression_tests#12 to enhance also the regression tests.

@yvantor
Copy link
Contributor

yvantor commented Mar 9, 2024

This PR is paired to pulp-platform/regression_tests#12 to enhance also the regression tests.

This PR was merged! If this is ready we can merge this as well.

@ricted98
Copy link
Contributor Author

Do we want to add a fault injection test to the CI? Otherwise, I think it is ready to merge.

@yvantor
Copy link
Contributor

yvantor commented Mar 11, 2024

@ricted98 Yes! We should have one test in the CI at least used as an example to replicate the flow.

@ricted98 ricted98 force-pushed the rt/fault-injection-rebase branch 6 times, most recently from 07720e1 to 1d6b1fe Compare March 11, 2024 16:55
@ricted98
Copy link
Contributor Author

Done. Everything should be now integrated also in the CI.

@yvantor
Copy link
Contributor

yvantor commented Mar 13, 2024

I merged also the regression tests PR. Closing this!

@yvantor yvantor merged commit 652401c into astral Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants