(CAT-1143)-Conversion_of_erb_templates_to_epp#944
Merged
Conversation
praj1001
force-pushed
the
CAT-1143-erb_to_epp_docker
branch
from
6d9828c to
16c7847
Compare
praj1001
force-pushed
the
CAT-1143-erb_to_epp_docker
branch
from
16c7847 to
3e101cb
Compare
Ramesh7
approved these changes
Aug 10, 2023
Ramesh7
left a comment
Ramesh7
left a comment
There was a problem hiding this comment.
LGTM
can we get one more review before we merge, as its big PR?
smortex
added a commit
that referenced
this pull request
Jan 8, 2024
In #944, we switched from ERB to EPP. This has not been released yet, but while testing I spotted some white space changes that where unexpected. Adjust the code so that the EPP template produce the same result as the ERB template did, making changes more relevant to end-users if they see some files being changed.
Ramesh7
pushed a commit
that referenced
this pull request
Jun 6, 2024
In #944, we switched from ERB to EPP. This has not been released yet, but while testing I spotted some white space changes that where unexpected. Adjust the code so that the EPP template produce the same result as the ERB template did, making changes more relevant to end-users if they see some files being changed.
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Jul 3, 2024
When these templates were converted from ERB to EPP in commit 3e101cb (puppetlabs#944), these lines were swapped, causing a whitespace change and unnecessary service restarts.
kenyon
added a commit
to kenyon/puppetlabs-docker
that referenced
this pull request
Jul 11, 2024
When these templates were converted from ERB to EPP in commit 3e101cb (puppetlabs#944), these lines were swapped, causing a whitespace change and unnecessary service restarts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conversion of ERB To EPP for templates in docker module.
Additional Context
Related Issues (if any)
Checklist
puppet apply)