systemd service overrides: restore whitespace to pre-conversion#983
Merged
Ramesh7 merged 1 commit intopuppetlabs:mainfrom Jul 12, 2024
Merged
systemd service overrides: restore whitespace to pre-conversion#983Ramesh7 merged 1 commit intopuppetlabs:mainfrom
Ramesh7 merged 1 commit intopuppetlabs:mainfrom
Conversation
When these templates were converted from ERB to EPP in commit 3e101cb (puppetlabs#944), these lines were swapped, causing a whitespace change and unnecessary service restarts.
kenyon
force-pushed
the
restore-template-whitespace
branch
from
1507886 to
b6ec597
Compare
bastelfreak
approved these changes
Jul 11, 2024
Ramesh7
approved these changes
Jul 12, 2024
|
Well, now it causing restart while upgrading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When these templates were converted from ERB to EPP in commit 3e101cb (#944), these lines were swapped, causing a whitespace change and unnecessary service restarts.