Add ability to override basedir and package type for oracle java

[esalberg]

Allow the installation of Oracle Java into custom directories; allow use of custom packages, e.g. homebuilt tar.gz files

[david22swan]

@esalberg Could you update the docs to account for your change please?

[david22swan]

@esalberg Sorry to bother you, but is this PR still active????

[esalberg]

Sorry about the delay. I have rebased and updated the Readme. Do you need documentation anywhere else? I haven’t had a chance yet to validate that everything fine after the rebase merge – I should have that done by mid next week. From: david22swan <notifications@github.com> Sent: Thursday, October 11, 2018 11:08 AM To: puppetlabs/puppetlabs-java <puppetlabs-java@noreply.github.com> Cc: Elyse Salberg <Elyse_Salberg@putnam.com>; Mention <mention@noreply.github.com> Subject: Re: [puppetlabs/puppetlabs-java] Add ability to override basedir and package type for oracle java (#298) @esalberg<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_esalberg&d=DwMCaQ&c=vYgbkq6q_4hmkgETKofs3A&r=dYP_6b0bY8kFzOVJ7ZLYv2UB6hf7GylA08dLczMmM-w&m=tcIq2CuZFxdgYSB9FXw2zmfIFKMdMScxssgat7b_GAU&s=uWlOrRiRVYioWTmSSnR5v2mQzSGXMsevJrQ541d9BVA&e=> Could you update the docs to account for your change please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_puppetlabs_puppetlabs-2Djava_pull_298-23issuecomment-2D428988271&d=DwMCaQ&c=vYgbkq6q_4hmkgETKofs3A&r=dYP_6b0bY8kFzOVJ7ZLYv2UB6hf7GylA08dLczMmM-w&m=tcIq2CuZFxdgYSB9FXw2zmfIFKMdMScxssgat7b_GAU&s=zmGlKNunDe-O_aa-WaiIEalMPm5hZnYDcS3tI_kViA0&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AI768rL8H4FBXlNhjC98AKzlU8mCTjEdks5uj17HgaJpZM4Vg4b5&d=DwMCaQ&c=vYgbkq6q_4hmkgETKofs3A&r=dYP_6b0bY8kFzOVJ7ZLYv2UB6hf7GylA08dLczMmM-w&m=tcIq2CuZFxdgYSB9FXw2zmfIFKMdMScxssgat7b_GAU&s=gppoohjmCM92bkk6B0ss6Qwbi_e2uWch8jRwoyzcxx8&e=>. This message is intended for the recipient only and is not meant to be forwarded or distributed in any other format. This communication is for informational purposes only. It is not intended as an offer or solicitation for the purchase or sale of any financial instrument, or security, or as an official confirmation of any transaction. Putnam does not accept purchase or redemptions of securities, instructions, or authorizations that are sent via e-mail. All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of Putnam Investments, LLC (DBA Putnam Investments) and its subsidiaries and affiliates. If you are not the intended recipient of this e-mail, please delete the e-mail. Information on how Putnam gathers and uses personal data is available in Putnam’s privacy notice which can be found at https://www.putnam.com/policies

[david22swan]

@esalberg The documentation you have now looks fine. Unfortunately the rebase seems to have caused some unit test failures however.

[esalberg]

Yes - I was having issues logging into Github. I will fix them next week. This message is intended for the recipient only and is not meant to be forwarded or distributed in any other format. This communication is for informational purposes only. It is not intended as an offer or solicitation for the purchase or sale of any financial instrument, or security, or as an official confirmation of any transaction. Putnam does not accept purchase or redemptions of securities, instructions, or authorizations that are sent via e-mail. All market prices, data and other information are not warranted as to completeness or accuracy and are subject to change without notice. Any comments or statements made herein do not necessarily reflect those of Putnam Investments, LLC (DBA Putnam Investments) and its subsidiaries and affiliates. If you are not the intended recipient of this e-mail, please delete the e-mail. Information on how Putnam gathers and uses personal data is available in Putnam’s privacy notice which can be found at https://www.putnam.com/policies

[fraenki]

@esalberg Ping :) I'd love to get this merged for the next release.

[david22swan]

@esalberg Any movement on this??

[david22swan]

@esalberg Sorry to eep pinging, but are you still interested in getting this merged?

[david22swan]

@esalberg Closing this as another contributor came along and finished it. Thank you for the work you put into it, it's thanks to you the change exists at all.