Add ability to override basedir and package type for oracle java#345
Merged
david22swan merged 3 commits intopuppetlabs:masterfrom Feb 12, 2019
markt-de:location_fix
Merged
Add ability to override basedir and package type for oracle java#345david22swan merged 3 commits intopuppetlabs:masterfrom markt-de:location_fix
david22swan merged 3 commits intopuppetlabs:masterfrom
markt-de:location_fix
Conversation
Member
Member
|
@fraenki All looks good to me, thanks for putting in the work to get this finished. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This is a resubmission of #298, because it looks like the original submitter lost interest.
In addition this fixes several small issues of the original submission:
$_basedirinstead of hardcoded valuesping @david22swan