Skip to content

Update package naming to differentiate between minor versions#533

Closed
sd-z wants to merge 0 commit intopuppetlabs:mainfrom
sd-z:main
Closed

Update package naming to differentiate between minor versions#533
sd-z wants to merge 0 commit intopuppetlabs:mainfrom
sd-z:main

Conversation

@sd-z
Copy link
Copy Markdown
Contributor

@sd-z sd-z commented Nov 2, 2022

Hi there,
i have opened an issue here: #532 describing the improvements. By providing the PR directly the process can be resolved whenever somebody has time for it.
Best Regards

@sd-z sd-z requested a review from a team as a code owner November 2, 2022 12:04
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 2, 2022

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link
Copy Markdown

java::download is a type

Breaking changes to this file WILL impact these 2 modules (exact match):

This module is declared in 79 of 579 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@chelnak
Copy link
Copy Markdown
Contributor

chelnak commented Nov 2, 2022

Hey @sd-z thank you for this PR.

Before we can move forward we will need you to sign the CLA.

Additionally, it looks like the changes proposed in this PR are causing some spec test failures. Could you take a look at these please?

@sd-z
Copy link
Copy Markdown
Contributor Author

sd-z commented Nov 2, 2022

Hi @chelnak,
thanks for the quick reply. I am currently looking into the cla as there seems to be some unexpected behaviour due to the Github user not being the commit owner. I will check the spec tests after :)
Best Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants