Update package naming to differentiate between minor versions#534
Merged
jordanbreen28 merged 4 commits intopuppetlabs:mainfrom Nov 7, 2022
Merged
Update package naming to differentiate between minor versions#534jordanbreen28 merged 4 commits intopuppetlabs:mainfrom
jordanbreen28 merged 4 commits intopuppetlabs:mainfrom
Conversation
java::download is a typeBreaking changes to this file WILL impact these 2 modules (exact match):This module is declared in 79 of 579 indexed public
|
Contributor
Author
|
As mentioned in the other PR I will look into the failing Spec Tests. |
Contributor
Author
|
I rewrote the rspec test values to fit the new archive naming. Tests should run successfully now. |
jordanbreen28
approved these changes
Nov 7, 2022
Contributor
jordanbreen28
left a comment
There was a problem hiding this comment.
Hi @sd-z!
Thanks for all your work on this.
Happy to approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I have opened up a new PR as the old one proved to be near to impossible to get through CLA as it included two different accounts. The old PR can be found here: #533
Best regards,