Add '--' after node eval and before node args#856
Merged
f-f merged 4 commits intopurescript:masterfrom Feb 12, 2022
JordanMartinez:fix-node-args
Merged
Add '--' after node eval and before node args#856f-f merged 4 commits intopurescript:masterfrom JordanMartinez:fix-node-args
f-f merged 4 commits intopurescript:masterfrom
JordanMartinez:fix-node-args
Conversation
3 tasks
f-f
approved these changes
Feb 12, 2022
Member
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
Looks great, thanks!
If you bump the release number in spago.cabal and in the Changelog we can also release this right away 🙂
Contributor
Author
|
Done! |
Member
|
Thank you! I won't be at a computer for a while, so it'd be great if any of you could run the |
Contributor
Author
|
I just ran |
Contributor
Author
Member
|
Did you run that on your fork? It needs to be run from this repo - IIRC you should be authorised to push to the repo, but if not I can fix this next time I'm at a keyboard |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #855
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊