Gh857 add run support for es modules#858
Merged
f-f merged 3 commits intopurescript:masterfrom Feb 16, 2022
Merged
Conversation
Contributor
Author
|
Note: pr #856 should happen before this one |
sigma-andex
force-pushed
the
GH857-add-run-support-for-es-modules
branch
from
8ec56c7 to
c8c8cbd
Compare
f-f
approved these changes
Feb 13, 2022
Member
f-f
left a comment
f-f
left a comment
There was a problem hiding this comment.
Just a small note about the changelog, but otherwise this is great!
CHANGELOG.md
Outdated
| Bugfixes | ||
| - Make `spago run` work when `node-args` includes flag-like value (#856) | ||
| Features: | ||
| - Make `spago run` use es modules for projects >= v0.15 |
Member
There was a problem hiding this comment.
This version has already been released. Could you move this to the unreleased section?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds support for es modules to
spago run, using es modules for versions >= v0.15Solves #857
Checklist:
READMEP.S.: the above checks are not compulsory to get a change merged, so you may skip them. However, taking care of them will result in less work for the maintainers and will be much appreciated 😊