Update timeline to return an active timeline object w/ attributes#572
Merged
jjlawren merged 12 commits intopushingkarmaorg:masterfrom Oct 2, 2020
maykar:timeline
Merged
Update timeline to return an active timeline object w/ attributes#572jjlawren merged 12 commits intopushingkarmaorg:masterfrom maykar:timeline
jjlawren merged 12 commits intopushingkarmaorg:masterfrom
maykar:timeline
Conversation
* timeline() creates and returns ClientTimeline objects with associated attributes and caching * Refactor isPlayingMedia to use the new attributes and fix it's default value
maykar
changed the title
Web clients can occasionally return no timelines if no media has been played on them or if nothing has played for a while, this prevents errors in those cases.
Hellowlol
reviewed
Sep 25, 2020
maykar
commented
Sep 25, 2020
jjlawren
requested changes
Sep 28, 2020
Co-authored-by: jjlawren <jjlawren@users.noreply.github.com>
Co-authored-by: jjlawren <jjlawren@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
timelineto create and return an active timeline object with associated attributes and cachingisPlayingMedia()to utilize changes and fixincludePauseddefault value (was False when docs stated True)