-
Notifications
You must be signed in to change notification settings - Fork 200
Update timeline to return an active timeline object w/ attributes #572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9bc7868
timeline() now returns ClientTimeline objects
maykar 7ae3fe2
Clarify docstrings
maykar adc8e7f
Remove default param in timeline call & fix docstring typo
maykar 0c50c2f
return empty list if `timelines()` comes back empty
maykar 2b95127
typo
maykar 50c84e4
Workaround for unresponsive clients
maykar 9a69a96
Use sendCommand rather than timelines() for PTP workaround
maykar c526a1d
Remove workaround, set timeline's wait default to 1
maykar cda34c3
set timelines() wait default to 0, document buggy behavior
maykar 83116d4
Use ClientTimeline.key for consistency
maykar 97729d2
cast playQueue's IDs as int
maykar 567debd
Add audio attribs & make casts bool from int where it makes sense.
maykar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.