Skip to content

refactor ModelChain. add SingleDiode modelchain #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wholmgren wants to merge 9 commits into from
Closed

refactor ModelChain. add SingleDiode modelchain #151

wholmgren wants to merge 9 commits into from

Conversation

@wholmgren
Copy link
Member

@wholmgren wholmgren commented Apr 18, 2016

I refactored ModelChain into a parent ModelChain class with subclasses SAPM and SingleDiode.

In doing so, I moved some solar position, irradiance, and weather prep work into ModelChain.prepare_inputs and this method is called during run_model.

@wholmgren wholmgren added this to the 0.4.0 milestone Apr 18, 2016
@wholmgren wholmgren force-pushed the singlediode-chain branch 2 times, most recently from aed4ead to 11f73ee Compare April 21, 2016 23:47
This was referenced May 22, 2016
Closed
Closed
@wholmgren wholmgren force-pushed the singlediode-chain branch from cd699da to 15f5444 Compare May 22, 2016 17:36
@wholmgren wholmgren mentioned this pull request May 22, 2016
Closed
@wholmgren
Copy link
Member Author

wholmgren commented May 22, 2016

closed in favor of #179.

@wholmgren wholmgren closed this May 22, 2016
@wholmgren wholmgren deleted the singlediode-chain branch August 28, 2018 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api enhancement

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

1 participant

@wholmgren