refactor ModelChain. add SingleDiode modelchain #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jforbess here's the latest PR that supports the CEC modules. I hope it's easier to pull and test. Note that you'll still need to manually add a few values to the |
Member
Author
|
closing in favor of #194. I'll let the branch live on for a little bit longer, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #151...
I refactored
ModelChaininto a parentModelChainclass with subclassesSAPMandSingleDiode. In doing so, I moved some solar position, irradiance, and weather prep work intoModelChain.prepare_inputs.prepare_inputsis called duringrun_model.I also rebased this code on the changes that added support for
SingleAxisTrackerand voltage/current/power scaling.I think that this is close to ready, but would appreciate testing and comments.