refactor: remove comparison between Keybinding and string#137
Closed
tlambert03 wants to merge 0 commit intopyapp-kit:mainfrom
Closed
refactor: remove comparison between Keybinding and string#137tlambert03 wants to merge 0 commit intopyapp-kit:mainfrom
tlambert03 wants to merge 0 commit intopyapp-kit:mainfrom
Conversation
tlambert03
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 31 31
Lines 1760 1758 -2
=========================================
- Hits 1760 1758 -2
☔ View full report in Codecov by Sentry. |
|
Thanks, that looks great ! I'll try to find some time to test it with napari to see if it changes anything in the UI. |
Member
Author
|
i don't know how this got closed! and now seem unable to reopen. lemme figure it out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #108
@Carreau, if you could review/confirm that this is what you wanted in #108 I'd appreciate it!
(looks like napari tests pass fine with this change)