Skip to content

refactor: remove comparison between Keybinding and string#146

Merged
tlambert03 merged 2 commits intopyapp-kit:mainfrom
tlambert03:keybinding-comp
Dec 16, 2023
Merged

refactor: remove comparison between Keybinding and string#146
tlambert03 merged 2 commits intopyapp-kit:mainfrom
tlambert03:keybinding-comp

Conversation

@tlambert03
Copy link
Copy Markdown
Member

repoening #137 which I somehow closed accidentally

cc @Carreau ... please comment here instead if/when you have time to test napari.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0140de7) 100.00% compared to head (bca0c3a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           31        31           
  Lines         1783      1781    -2     
=========================================
- Hits          1783      1781    -2     
Files Coverage Δ
src/app_model/types/_keys/_keybindings.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03 tlambert03 merged commit 88ded30 into pyapp-kit:main Dec 16, 2023
@tlambert03 tlambert03 deleted the keybinding-comp branch December 16, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant