Skip to content

build: drop python 3.8 add py3.13#671

Merged
tlambert03 merged 6 commits intopyapp-kit:mainfrom
tlambert03:py313
Nov 9, 2024
Merged

build: drop python 3.8 add py3.13#671
tlambert03 merged 6 commits intopyapp-kit:mainfrom
tlambert03:py313

Conversation

@tlambert03
Copy link
Member

No description provided.

@tlambert03 tlambert03 changed the title build: add py3.13 build: drop python 3.8 add py3.13 Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.97%. Comparing base (ca6b595) to head (050d3df).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/magicgui/_type_resolution.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   89.16%   88.97%   -0.20%     
==========================================
  Files          39       39              
  Lines        4746     4743       -3     
==========================================
- Hits         4232     4220      -12     
- Misses        514      523       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlambert03
Copy link
Member Author

note that I'm removing one test here:

    assert resolve_single_type(Optional['List["numpy.ndarray"]']) == Optional[List[np.ndarray]]

Optional['List[numpy.ndarray]'] will work, but you can't add an arbitrarily nested number of strings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant