fix: fix safe_issubclass for NewType

[Czaki]

Closes napari/napari#7129

Today I learn that such code:

new_int = NewType("new_int", int)

issubclass(new_int, new_int)

Raises exception instead of returning True.

So this PR is a followup to #665 to fully resolve the upstream napari bug.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (021654f) to head (fbe381b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   88.87%   88.85%   -0.02%     
==========================================
  Files          39       39              
  Lines        4754     4756       +2     
==========================================
+ Hits         4225     4226       +1     
- Misses        529      530       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Czaki]

@tlambert03 The #671 changed type annotation used in tests/test_util.py making many test repetitive.
Should we restore these changes or simplify tests?

[tlambert03]

Should we restore these changes or simplify tests?

ah, i think these should probably be restored. since typing.List is still not an alias for list (in fact they don't even equal each other), it probably doesn't hurt to just keep checking that the typing objects work explicitly

[tlambert03]

Thanks!

[tlambert03]

Do you need this released asap? Can it wait a week or so to give time for testing the current pre-release? Or would you prefer a cherry pick back-release

[Czaki]

This is a question to @psobolewskiPhD

[psobolewskiPhD]

I mean it's been around and it only affects things that didn't update to drop older python, so I don't think it's critical?
I think being able to update the image.sc thread that it's been fixed and say look for a new magicgui release in a week or 2 should be fine?

[tlambert03]

Sounds good thanks

[imagesc-bot]

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/help-with-napari-unicell-plugin/105331/15