Add numba to nightly upstream #7311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw that we didn't have this while investigating numba/numba#8615. We should probably wait until that's resolved before merging this (this doesn't solve that issue).
max-sixty
commented
Nov 22, 2022
| h5netcdf \ | ||
| matplotlib \ | ||
| numpy \ | ||
| numba \ |
Collaborator
Author
There was a problem hiding this comment.
This is the only semantic change; the others are just sorting the lines
keewis
reviewed
Nov 22, 2022
| git+https://github.com/pypa/packaging \ | ||
| git+https://github.com/h5netcdf/h5netcdf | ||
| git+https://github.com/hgrecco/pint \ | ||
| git+https://github.com/numba/numba \ |
Collaborator
There was a problem hiding this comment.
does numba require compilation? If so, it might be better to use pre-built packages (if numba provides those?).
2 tasks
Contributor
|
Since numba won't support numpy |
Collaborator
Author
Yes, I'll get to it if no one gets there first. I guess we also need to disable those tests |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that we didn't have this while investigating numba/numba#8615. We should probably wait until that's resolved before merging this (this doesn't solve that issue).