Skip to content

Conversation

@max-sixty
Copy link
Collaborator

No description provided.

@max-sixty max-sixty enabled auto-merge (squash) June 25, 2024 00:00
@max-sixty max-sixty disabled auto-merge June 25, 2024 00:00
@max-sixty max-sixty added the run-upstream Run upstream CI label Jun 25, 2024
@max-sixty
Copy link
Collaborator Author

This fixes the upstream error from no numbagg library being available, though there are other failures

@max-sixty max-sixty enabled auto-merge (squash) June 25, 2024 00:11
@max-sixty max-sixty disabled auto-merge June 25, 2024 00:12
@max-sixty
Copy link
Collaborator Author

This will need to wait until the next numba release, which supports numpy 2.0...

@keewis
Copy link
Collaborator

keewis commented Jun 25, 2024

from what I remember, in #7311 we decided not to install numba in the upstream-dev CI because it can't handle any version upgrade of numpy. Do we want to revisit that?

@max-sixty
Copy link
Collaborator Author

from what I remember, in #7311 we decided not to install numba in the upstream-dev CI because it can't handle any version upgrade of numpy. Do we want to revisit that?

Yes, that's a good point — I think this is intractable unless numba tries to be forward-compatible with numpy. So will close.

We'll need another solution for the upstream mypy error, though it's one of many many there...

@max-sixty max-sixty closed this Jun 25, 2024
@keewis
Copy link
Collaborator

keewis commented Jun 25, 2024

yeah, someone will have to have a look at the mypy upstream-dev CI at some point. Though now that we actually test the released numpy>=2 in the normal mypy CI (a dependency stopped pinning it), these are also failing now.

@max-sixty
Copy link
Collaborator Author

yeah, someone will have to have a look at the mypy upstream-dev CI at some point.

Yes, mostly tracked in #9155 — most of the failures are a change in mypy versions rather than our library versions...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-upstream Run upstream CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants