Fold the exclusions of scalars from the hestenes dot product into the table#134
Merged
utensil merged 1 commit intopygae:masterfrom Dec 6, 2019
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
eric-wieser
force-pushed
the
remove-hestenes-special-case
branch
from
efff455 to
e1b1c92
Compare
eric-wieser
force-pushed
the
remove-hestenes-special-case
branch
2 times, most recently
from
c8550c8 to
108519a
Compare
eric-wieser
force-pushed
the
remove-hestenes-special-case
branch
from
108519a to
b1bbc27
Compare
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
+ Coverage 67.53% 67.54% +<.01%
==========================================
Files 8 8
Lines 4796 4794 -2
==========================================
- Hits 3239 3238 -1
+ Misses 1557 1556 -1
Continue to review full report at Codecov.
|
eric-wieser
force-pushed
the
remove-hestenes-special-case
branch
from
b1bbc27 to
945c18d
Compare
… table This means that `ga.dot_table_dict[S(1), S(1)] == S(0)`, whereas previously it was incorrectly 1.
eric-wieser
force-pushed
the
remove-hestenes-special-case
branch
from
945c18d to
e301aee
Compare
eric-wieser
commented
Dec 6, 2019
Comment on lines
-96
to
-98
| if (isinstance(expr1, numbers.Number) or expr1.is_commutative) \ | ||
| or (isinstance(expr2, numbers.Number) or expr2.is_commutative): | ||
| return expr1 * expr2 |
Member
Author
There was a problem hiding this comment.
This part was actually incorrect for for when mul_dict[S(1), S(1)] != S(1), like it is for the hestenes dot
Member
Author
There was a problem hiding this comment.
I suppose strictly this change could go in all by itself
Member
|
Some remarks:
from Clifford Algebra to Geometric Calculus. |
utensil
approved these changes
Dec 6, 2019
Member
utensil
left a comment
utensil
left a comment
There was a problem hiding this comment.
It took me some time to map the diff to formulas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from an earlier PR (#99) that failed CI. This part strikes me as the part that wasn't wrong.
It's not particularly useful, but this now means that
ga.dot_table_dict[S(1), S(1)]now returns 0 and not 1.This does not affect the output of the
hestenes_dotfunction, it just brings the table in line with it.