Eliminate _dot, which is now easy to inline into Mul#142
Merged
utensil merged 1 commit intopygae:masterfrom Dec 8, 2019
Merged
Eliminate _dot, which is now easy to inline into Mul#142utensil merged 1 commit intopygae:masterfrom
_dot, which is now easy to inline into Mul#142utensil merged 1 commit intopygae:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 67.27% 67.23% -0.04%
==========================================
Files 8 8
Lines 4776 4774 -2
==========================================
- Hits 3213 3210 -3
- Misses 1563 1564 +1
Continue to review full report at Codecov.
|
utensil
reviewed
Dec 8, 2019
| The :attr:`dot_mode` attribute determines which of these is used. | ||
| """ | ||
| return self._dot(A, B, mode=self.dot_mode) | ||
| # forbid something silly like setting dot_mode to the wedge or geometric |
utensil
approved these changes
Dec 8, 2019
Member
Author
|
Coverage failure looks pretty safe, it's just observing that we never call |
eric-wieser
added a commit
to eric-wieser/galgebra
that referenced
this pull request
Dec 18, 2019
`_dot` was removed in pygaegh-142, but when inlining, this call site was missed.
utensil
pushed a commit
that referenced
this pull request
Dec 18, 2019
`_dot` was removed in gh-142, but when inlining, this call site was missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the previous PR's removing special cases for scalars (#134, #99), it's now apparent that
_dotis a trivial function that can be inlined at its call sites