Skip to content

Simplify kwarg parsing in _make_grade#96

Merged
utensil merged 2 commits intopygae:masterfrom
eric-wieser:simplify-_make_grade
Dec 4, 2019
Merged

Simplify kwarg parsing in _make_grade#96
utensil merged 2 commits intopygae:masterfrom
eric-wieser:simplify-_make_grade

Conversation

@eric-wieser
Copy link
Member

Some small cleanup before stricter kwarg validation

@eric-wieser eric-wieser requested a review from utensil December 2, 2019 09:50
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #96 into master will increase coverage by <.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   67.62%   67.63%   +<.01%     
==========================================
  Files           8        8              
  Lines        4788     4789       +1     
==========================================
+ Hits         3238     3239       +1     
  Misses       1550     1550
Impacted Files Coverage Δ
galgebra/mv.py 63.06% <80%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09ecbd1...0de7425. Read the comment docs.

Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@utensil utensil merged commit df6d338 into pygae:master Dec 4, 2019
@eric-wieser eric-wieser deleted the simplify-_make_grade branch December 8, 2019 10:56
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
@eric-wieser eric-wieser added the component: core Ga, Mv, Metric, etc label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: core Ga, Mv, Metric, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants