Be stricter about kwargs to Mv.__init__#97
Conversation
a43d9c6 to
540bf14
Compare
Also add much better documentation for construction
540bf14 to
3a63d4f
Compare
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 67.63% 67.71% +0.07%
==========================================
Files 8 8
Lines 4789 4810 +21
==========================================
+ Hits 3239 3257 +18
- Misses 1550 1553 +3
Continue to review full report at Codecov.
|
|
Trying to get github to recompute the diff... |
utensil
left a comment
There was a problem hiding this comment.
Cool! Although I missed the old init_slot a bit as it partially served as a doc.
Also, I would like the new private class to have its own tests but it's well covered.
New docs are here https://galgebra.readthedocs.io/en/latest/generated/galgebra.mv.html#galgebra.mv.Mv.Mv The old ones were misleading, as they only applied to some permutations of arguments. |
Yup, I get that part. |
Also add much better documentation for construction (https://external-builds.readthedocs.io/html/galgebra/97/generated/galgebra.mv.html#galgebra.mv.Mv)
Builds upon #96, posting now to solve any CI issues
Bonus!