Skip to content

Be stricter about kwargs to Mv.__init__#97

Merged
utensil merged 1 commit intopygae:masterfrom
eric-wieser:strict-mv-kwargs
Dec 4, 2019
Merged

Be stricter about kwargs to Mv.__init__#97
utensil merged 1 commit intopygae:masterfrom
eric-wieser:strict-mv-kwargs

Conversation

@eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 2, 2019

Also add much better documentation for construction (https://external-builds.readthedocs.io/html/galgebra/97/generated/galgebra.mv.html#galgebra.mv.Mv)


Builds upon #96, posting now to solve any CI issues

Bonus!

image

@eric-wieser eric-wieser force-pushed the strict-mv-kwargs branch 4 times, most recently from a43d9c6 to 540bf14 Compare December 2, 2019 11:21
Also add much better documentation for construction
@codecov
Copy link

codecov bot commented Dec 2, 2019

Codecov Report

Merging #97 into master will increase coverage by 0.07%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   67.63%   67.71%   +0.07%     
==========================================
  Files           8        8              
  Lines        4789     4810      +21     
==========================================
+ Hits         3239     3257      +18     
- Misses       1550     1553       +3
Impacted Files Coverage Δ
galgebra/deprecated.py 98.52% <100%> (+0.06%) ⬆️
galgebra/utils.py 71.87% <78.57%> (+5.2%) ⬆️
galgebra/mv.py 63.15% <90.9%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be31380...3a63d4f. Read the comment docs.

@eric-wieser eric-wieser marked this pull request as ready for review December 4, 2019 15:20
@eric-wieser eric-wieser closed this Dec 4, 2019
@eric-wieser eric-wieser reopened this Dec 4, 2019
@eric-wieser
Copy link
Member Author

Trying to get github to recompute the diff...

@eric-wieser eric-wieser closed this Dec 4, 2019
@eric-wieser eric-wieser reopened this Dec 4, 2019
@eric-wieser eric-wieser changed the base branch from master to 0.4.4-release December 4, 2019 15:22
@eric-wieser eric-wieser changed the base branch from 0.4.4-release to master December 4, 2019 15:22
@eric-wieser eric-wieser requested a review from utensil December 4, 2019 15:22
@pygae pygae deleted a comment from lgtm-com bot Dec 4, 2019
Copy link
Member

@utensil utensil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Although I missed the old init_slot a bit as it partially served as a doc.

Also, I would like the new private class to have its own tests but it's well covered.

@utensil utensil merged commit e1f77bd into pygae:master Dec 4, 2019
@eric-wieser
Copy link
Member Author

eric-wieser commented Dec 4, 2019

Cool! Although I missed the old init_slot a bit as it partially served as a doc.

New docs are here https://galgebra.readthedocs.io/en/latest/generated/galgebra.mv.html#galgebra.mv.Mv.Mv

The old ones were misleading, as they only applied to some permutations of arguments.

@utensil
Copy link
Member

utensil commented Dec 5, 2019

The old ones were misleading, as they only applied to some permutations of arguments.

Yup, I get that part.

@eric-wieser eric-wieser deleted the strict-mv-kwargs branch December 8, 2019 10:56
@utensil utensil added this to the 0.4.5 milestone Dec 18, 2019
@eric-wieser eric-wieser added the component: core Ga, Mv, Metric, etc label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: core Ga, Mv, Metric, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants