-
Notifications
You must be signed in to change notification settings - Fork 92
Update cairo bundled in windows wheels #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14dd62d to
8649126
Compare
stuaxo
reviewed
Oct 21, 2021
stuaxo
reviewed
Oct 21, 2021
c599b09 to
482720a
Compare
Contributor
Author
|
Now that Cairo 1.17.6 is out I'll try this PR with that version. |
Contributor
Author
|
It's getting fun: the tests are failing with a |
Contributor
Author
|
there's only one error now after updating release with the patch related to dwrite: pygobject/cairo-win-build@0f53b7d _________________________ test_pdf_version_to_string __________________________
def test_pdf_version_to_string():
ver = cairo.PDFSurface.version_to_string(cairo.PDF_VERSION_1_4)
assert ver and isinstance(ver, str)
with pytest.raises(ValueError):
> cairo.PDFSurface.version_to_string(-1)
E Failed: DID NOT RAISE <class 'ValueError'>
tests\test_surface.py:306: Failed
=========================== short test summary info ===========================
FAILED tests/test_surface.py::test_pdf_version_to_string - Failed: DID NOT RA...
================== 1 failed, 269 passed, 5 skipped in 22.47s ================== |
612cbab to
4c1e7a5
Compare
9b14be4 to
e7e3495
Compare
- Closes pygobject#242. - Use a prebuilt version of Cairo from https://github.com/pygobject/cairo-win-build, https://github.com/pygobject/cairo-win-build/releases/tag/1.17.6. It's a static build of Cairo. - Use pkg-config for finding build flags even on Windows/MSVC compiler. - Build and test wheels using [cibuildwheel](https://cibuildwheel.readthedocs.io) for Windows.
e7e3495 to
03a5f54
Compare
lazka
reviewed
Oct 16, 2022
… option `PYCAIRO_BUILD_NO_PKGCONFIG, used when we shouldn't use pkg-config `PYCAIRO_BUILD_MSVC_STATIC`: used when we are building with static libraries of cairo defaults to True.
Contributor
Author
|
Thanks! |
Member
|
thank you! sorry for the delay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.