pdf_version_to_string: Check for negative values
#279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an upstream bug, passing negative values to `cairo_pdf_version_to_string` can cause out-of-bound memory address access, in some specific cases. Avoid that by checking for negative values, before calling that function. See https://gitlab.freedesktop.org/cairo/cairo/-/issues/590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an upstream bug, passing negative values to
cairo_pdf_version_to_stringcan cause out-of-bound memory address access, in some specific cases. Avoid that by checking for negative values, before calling that function.See https://gitlab.freedesktop.org/cairo/cairo/-/issues/590 and https://gitlab.freedesktop.org/cairo/cairo/-/merge_requests/358
Fixes the error seen in #243 (comment)
cc @lazka