Skip to content

pdf_version_to_string: Check for negative values #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazka merged 1 commit into from
Sep 16, 2022
Merged

pdf_version_to_string: Check for negative values #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions cairo/surface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,9 +1291,19 @@ pdf_version_to_string (PyObject *self, PyObject *args) {

version = (cairo_pdf_version_t)version_arg;

Py_BEGIN_ALLOW_THREADS;
version_string = cairo_pdf_version_to_string (version);
Py_END_ALLOW_THREADS;
/* See https://gitlab.freedesktop.org/cairo/cairo/-/issues/590
* if version < 0, cairo_pdf_version_to_string will return out-of-bound
* memory address and could cause problems. We avoid those by checking
* whether the version is greater than 0 and only then calling
* that function.
*/
if (version >= 0) {
Py_BEGIN_ALLOW_THREADS;
version_string = cairo_pdf_version_to_string (version);
Py_END_ALLOW_THREADS;
} else {
version_string = NULL;
}

if (version_string == NULL) {
PyErr_SetString (PyExc_ValueError, "invalid version");
Expand Down