Modernise codebase#74
Merged
Merged
Conversation
FFY00
reviewed
Sep 25, 2021
pradyunsg
force-pushed
the
aug-2021-burst
branch
2 times, most recently
from
04cbf0f to
b39d2b1
Compare
pradyunsg
force-pushed
the
aug-2021-burst
branch
4 times, most recently
from
7119e70 to
2c2e1c8
Compare
Closed
Member
|
@pradyunsg would it be possible to have a release with #75 or whatever fixes the interfaces to allow us to add a bytecode generation step before this gets merged? Otherwise, I'd have to maintain a fork. |
Member
Author
|
Yup yup, I intend to cut a 0.3.0 release before merging this. |
1 task
pradyunsg
force-pushed
the
aug-2021-burst
branch
from
2c2e1c8 to
5506228
Compare
These are no longer necessary, as all compatible versions of Python have a capable version of `typing`.
The output has been reformatted with black, with 3 instances fixed by wrapping the types in a string. ``` src/installer/sources.py:119:45: F821 undefined name 'WheelFile' src/installer/records.py:69:31: F821 undefined name 'Hash' src/installer/records.py:146:68: F821 undefined name 'RecordEntry' ```
This is no longer necessary.
This is no longer necessary, since we're on a modern-enough versions of Python.
This makes the paths printed in the test outputs match the source tree, which makes it easier to navigate to the offending lines with a compatible terminal.
Otherwise, this causes an exception at runtime.
Already dropped support for Python <= 3.6.
pradyunsg
force-pushed
the
aug-2021-burst
branch
from
5506228 to
283604c
Compare
pradyunsg
commented
Oct 13, 2021
Member
Author
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
Self-reviewed, and it looks good. 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because it can't hurt to flesh this out publicly.
Closes #42
Closes #43