Include schemes with records, when calling finalise_installation#75
Merged
Conversation
Member
Author
|
This is needed for the bytecode generation step afterwards. This commit is/was part of #66 but I have created a separate PR to speed up review. This is the only thing preventing me from providing a CLI in a 3rd party package. |
FFY00
force-pushed
the
install-return-records
branch
4 times, most recently
from
4654baf to
13b8204
Compare
pradyunsg
requested changes
Sep 27, 2021
FFY00
force-pushed
the
install-return-records
branch
2 times, most recently
from
6306a5c to
9cedef5
Compare
FFY00
changed the title
Merged
FFY00
force-pushed
the
install-return-records
branch
2 times, most recently
from
f879826 to
5291351
Compare
Closed
Member
Author
|
@pradyunsg friendly ping. |
pradyunsg
reviewed
Oct 11, 2021
Member
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
This looks great, although I'd strongly prefer to not have a mapping here.
I'll cut a 0.4.0 with this, once that is changed, that is Python 2 compatible -- only because you're nice and have been super helpful with this project. :)
Member
Author
|
Thank you, I will have a look tomorrow. |
Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
install-return-records
branch
from
5291351 to
118a59a
Compare
Member
Author
|
Sorry for the delay. |
pradyunsg
approved these changes
Oct 13, 2021
pradyunsg
changed the title
finalise_installation
pradyunsg
changed the title
finalise_installationfinalise_installation
Member
No worries! ^>^ Here you go: https://pypi.org/project/installer/0.4.0/ |
frostming
reviewed
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Filipe Laíns lains@riseup.net