Restrict coverage version to '<5.0.0'#247
Merged
Merged
Conversation
Member
|
@mayeut could you also update the GitHub Actions (either by unrolling Python support to call each supported version of Python via Tox individually/manually or update the dependency install)? |
brettcannon
requested changes
Dec 17, 2019
Member
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
Also need to update the GitHub Action to either directly use Tox by unrolling the Python version support or tweaking the dependency requirement for 'coverage'.
Member
Author
|
For some reason, GitHub Action wasn't triggered by this PR so I missed that update. It's now done. |
Member
|
@mayeut thanks! GH Actions wasn't triggered because there's no code change to trigger for 😄 |
Member
Author
Good to know, thanks. Too bad it wasn't triggered either when I changed the workflow itself. |
mayeut
added a commit
to mayeut/packaging
that referenced
this pull request
Dec 17, 2019
mayeut
added a commit
to mayeut/packaging
that referenced
this pull request
Dec 17, 2019
brettcannon
pushed a commit
that referenced
this pull request
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mitigate #246
I don't think this is a long-term solution but I couldn't figure out how to do this properly with coverage 5.0.0
Might be a bug in coverage, wait & see.